Omnibus service fix and template improvement #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add restart, start, stop, status commands as parameters * Perform osfamily decisions in params class to simplify service class * service class uses ::gitlab variables directly since all the logic is outside the service class
* Sorting these keys will keep the file in a predictable and repeatable order regardless of the input. This will help with idempotency.
jrwesolo
force-pushed
the
omnibus-service-fix
branch
from
ea0aee1 to
8d03ac1
Compare
tobru
added a commit
that referenced
this pull request
Jul 7, 2015
Omnibus service fix and template improvement
|
Thanks a lot for this great contribution. Will do a new release today... |
b4ldr
referenced
this pull request
in icann-dns/puppet-gitlab
Apr 3, 2018
# This is the 1st commit message: . # This is the commit message #2: remove duplicate githooks # This is the commit message #3: Refactor cirunners - - update # This is the commit message #4: add deprecation notice # This is the commit message #5: add travis secret for publishing module # This is the commit message #6: release 1.16.0 # This is the commit message #7: rename changelog for release gem # This is the commit message voxpupuli#8: rewrite changelog with github-changelog-generator # This is the commit message voxpupuli#9: [blacksmith] Bump version to 1.16.1-rc0 # This is the commit message voxpupuli#10: modulesync 1.7.0 # This is the commit message voxpupuli#11: modulesync 1.7.0 take 2 # This is the commit message voxpupuli#12: fix spec test hiera location # This is the commit message voxpupuli#13: release 1.16.1 # This is the commit message voxpupuli#14: [blacksmith] Bump version to 1.16.2-rc0 # This is the commit message voxpupuli#15: Propose small spelling change # This is the commit message voxpupuli#16: Fixed redhat installation # This is the commit message voxpupuli#17: add letsencrypt section to gitlab.rb # This is the commit message voxpupuli#18: I think there were some minor problems with voxpupuli#155. This allows managing the backup cron w/o managing the config file and fixing SKIP syntax. # This is the commit message voxpupuli#19: setup fast indexing of ssh keys # This is the commit message voxpupuli#20: add unit test for store_git_keys_in_db # This is the commit message voxpupuli#21: added docs for using store_git_keys_in_db feature # This is the commit message voxpupuli#22: add variable to scope # This is the commit message voxpupuli#23: update regex in ssh fast lookup spec # This is the commit message voxpupuli#24: another stab at regex # This is the commit message voxpupuli#25: typo correction # This is the commit message voxpupuli#26: checking file exists first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing this on CentOS 6.6 and was running into issues with the service being managed correctly. Since we are using the omnibus package regardless of os, let's use the gitlab-ctl commands all the time. I also experienced an issue where the gitlab.rb template was changing the order of config lines on subsequent runs which would result in unnecessary restarts of gitlab. I changed the template to sort the keys of the hash first and that alleviated the problem. This is nice in general for a clean and organized config.